-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-132011: Fix crash on invalid CALL_LIST_APPEND
deoptimization
#132018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Victor Stinner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, with two English-related nitpicks.
Misc/NEWS.d/next/Core_and_Builtins/2025-04-02-17-47-14.gh-issue-132011.dNh64H.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Bierma <[email protected]>
Misc/NEWS.d/next/Core_and_Builtins/2025-04-02-17-47-14.gh-issue-132011.dNh64H.rst
Outdated
Show resolved
Hide resolved
…e-132011.dNh64H.rst Co-authored-by: Peter Bierma <[email protected]>
(not merging, because I am waiting for @markshannon's review as code owner) |
Going to merge soon, since I don't want to create and resolve merge conflicts on generated files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @sobolevn, I could not cleanly backport this to
|
…imization (pythonGH-132018) (cherry picked from commit c0661df) Co-authored-by: sobolevn <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
GH-132161 is a backport of this pull request to the 3.13 branch. |
…ion (GH-132018) (#132161) * [3.13] gh-132011: Fix crash on invalid `CALL_LIST_APPEND` deoptimization (GH-132018) (cherry picked from commit c0661df) Co-authored-by: sobolevn <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
…on (python#132018) Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
Looks similar to #132000
_PyEval_EvalFrameDefault
:self_o != NULL
#132011