Skip to content

gh-132011: Fix crash on invalid CALL_LIST_APPEND deoptimization #132018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 6, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 2, 2025

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Victor Stinner <[email protected]>
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, with two English-related nitpicks.

@sobolevn
Copy link
Member Author

sobolevn commented Apr 3, 2025

(not merging, because I am waiting for @markshannon's review as code owner)

@sobolevn
Copy link
Member Author

sobolevn commented Apr 6, 2025

Going to merge soon, since I don't want to create and resolve merge conflicts on generated files.

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobolevn sobolevn merged commit c0661df into python:main Apr 6, 2025
64 checks passed
@sobolevn sobolevn added the needs backport to 3.13 bugs and security fixes label Apr 6, 2025
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c0661df42ad20e488dbfa3e0fec22462833fc3d6 3.13

sobolevn added a commit to sobolevn/cpython that referenced this pull request Apr 6, 2025
…imization (pythonGH-132018)

(cherry picked from commit c0661df)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 6, 2025

GH-132161 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 6, 2025
sobolevn added a commit that referenced this pull request Apr 6, 2025
…ion (GH-132018) (#132161)

* [3.13] gh-132011: Fix crash on invalid `CALL_LIST_APPEND` deoptimization (GH-132018)
(cherry picked from commit c0661df)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants